Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update maxRevisionCost check to match the way hostd computes LatestRevisionCost #1112

Merged
merged 2 commits into from
Mar 27, 2024
Merged

Update maxRevisionCost check to match the way hostd computes LatestRevisionCost #1112

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a6c306d
worker: update maxRevisionCost check to match the way hostd computes …
ChrisSchinnerl Mar 27, 2024
aaab735
e2e: fix TestGouging
ChrisSchinnerl Mar 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion worker/gouging.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,10 @@ func checkPriceGougingPT(gs api.GougingSettings, cs api.ConsensusState, txnFee t
}

// check LatestRevisionCost - expect sane value
maxRevisionCost := gs.MaxDownloadPrice.Div64(1 << 40).Mul64(4096)
maxRevisionCost, overflow := gs.MaxRPCPrice.AddWithOverflow(gs.MaxDownloadPrice.Div64(1 << 40).Mul64(2048))
ChrisSchinnerl marked this conversation as resolved.
Show resolved Hide resolved
if overflow {
maxRevisionCost = types.MaxCurrency
}
if pt.LatestRevisionCost.Cmp(maxRevisionCost) > 0 {
return fmt.Errorf("LatestRevisionCost of %v exceeds maximum cost of %v", pt.LatestRevisionCost, maxRevisionCost)
}
Expand Down
Loading