Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "transaction spends nonexisting siacoin output" when refreshing contracts #1111

Merged
merged 2 commits into from
Mar 28, 2024

Conversation

ChrisSchinnerl
Copy link
Member

@ChrisSchinnerl ChrisSchinnerl commented Mar 27, 2024

UnconfirmedParents would only ever return direct parents for a txn but not grandparents and so on. Leading to hosts not knowing about certain parents yet and txns failing.

@ChrisSchinnerl ChrisSchinnerl marked this pull request as ready for review March 27, 2024 11:41
@ChrisSchinnerl ChrisSchinnerl requested a review from peterjan March 27, 2024 11:42
Copy link
Member

@peterjan peterjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, nice one! This was annoying.

@peterjan peterjan merged commit c3155f8 into dev Mar 28, 2024
8 checks passed
@peterjan peterjan deleted the chris/unconfirmed-parents branch March 28, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants