-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate renterd
subscriber to coreutils
types
#1098
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marked as |
ChrisSchinnerl
requested changes
Apr 3, 2024
peterjan
commented
Apr 5, 2024
peterjan
changed the title
Migrate to
Migrate consensus to May 3, 2024
coreutils
typescoreutils
types
peterjan
changed the title
Migrate consensus to
Migrate May 3, 2024
coreutils
typesrenterd
subscriber to coreutils
types
peterjan
force-pushed
the
pj/subscription-api
branch
from
May 7, 2024 13:30
450cde6
to
db04139
Compare
peterjan
force-pushed
the
pj/subscription-api
branch
from
May 7, 2024 13:31
db04139
to
783f480
Compare
ChrisSchinnerl
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
core
andcoreutils
and splits the subscriber logic off into its own package calledchain
. This PR is the last step in migrating to thecoreutils
types and the new subscriber pattern.