Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debug logging and various minor logging improvements #1089

Merged
merged 11 commits into from
Mar 28, 2024
Merged

Debug logging and various minor logging improvements #1089

merged 11 commits into from
Mar 28, 2024

Conversation

ChrisSchinnerl
Copy link
Member

@ChrisSchinnerl ChrisSchinnerl commented Mar 21, 2024 •
edited
Loading

This PR

  • adds some logging to contract pruning
  • updates the revision fetch logging to break up the errors to make the log look a bit nicer. Also updates it to WARN instead ERROR since there is nothing the user can do in most cases.
  • adds some logging in the stores for when a sector is added but the contract doesn't exist
  • log a warning on startup when AVX2 isn't available similar to how hostd does
  • only log refill errors for contracts currently in the set

@ChrisSchinnerl
stores: add logging; worker: add debug logging for pruning; cmd: add …
d483b00 
…name to sql logger; contractor; break revision errors up into multiple log lines
@ChrisSchinnerl ChrisSchinnerl self-assigned this Mar 21, 2024
@ChrisSchinnerl ChrisSchinnerl force-pushed the chris/improve-logging branch from 679aa40 to 9fc5127 Compare March 27, 2024 11:50
@ChrisSchinnerl ChrisSchinnerl marked this pull request as ready for review March 27, 2024 11:55
@ChrisSchinnerl ChrisSchinnerl requested a review from peterjan March 27, 2024 11:55
peterjan
peterjan reviewed Mar 28, 2024
View reviewed changes
api/worker.go Outdated Show resolved Hide resolved
@ChrisSchinnerl ChrisSchinnerl merged commit e31b792 into dev Mar 28, 2024
8 checks passed
@ChrisSchinnerl ChrisSchinnerl deleted the chris/improve-logging branch March 28, 2024 12:08
@github-actions github-actions bot mentioned this pull request May 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterjan peterjan peterjan approved these changes

Assignees

@ChrisSchinnerl ChrisSchinnerl

Labels
None yet
Projects
Sia
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChrisSchinnerl @peterjan