Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isolate contractor into its own package #1083

Merged
merged 10 commits into from
Apr 4, 2024
Merged

Conversation

ChrisSchinnerl
Copy link
Member

This PR prepares the contractor for a slight refactor that makes it more unit-testable by detangling it from the Autopilot first.

@ChrisSchinnerl ChrisSchinnerl self-assigned this Mar 19, 2024
Base automatically changed from chris/no-more-collateral-gouging to dev March 20, 2024 12:02
@ChrisSchinnerl ChrisSchinnerl force-pushed the chris/contractor-refactor branch from 5cd4c1b to 4b31b83 Compare March 20, 2024 12:42
@ChrisSchinnerl
Copy link
Member Author

Blocker to not merge before #1085

@ChrisSchinnerl ChrisSchinnerl marked this pull request as ready for review March 20, 2024 16:24
@ChrisSchinnerl ChrisSchinnerl requested a review from peterjan March 20, 2024 16:25
Copy link
Member

@peterjan peterjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, finally tackling some of that contractor spaghetti 💪

internal/utils/errors.go Show resolved Hide resolved
autopilot/autopilot.go Show resolved Hide resolved
autopilot/contractor/contractor.go Outdated Show resolved Hide resolved
autopilot/contractor/contractor.go Show resolved Hide resolved
autopilot/contractor/contractor.go Show resolved Hide resolved
autopilot/contractor/contractor.go Outdated Show resolved Hide resolved
autopilot/contractor/contractor.go Outdated Show resolved Hide resolved
@ChrisSchinnerl ChrisSchinnerl requested a review from peterjan April 3, 2024 11:06
@ChrisSchinnerl ChrisSchinnerl merged commit c1492e8 into dev Apr 4, 2024
8 checks passed
@ChrisSchinnerl ChrisSchinnerl deleted the chris/contractor-refactor branch April 4, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants