Move host info to the bus
#1077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will add an integration test but figured it'd be best to push it into review and get a first round of comments in before doing so. |
|
This seems alright overall but can we extract the |
Jup, just wanted to get everything coded up to avoid going back and fourth between PRs. Moving this to |
peterjan
commented
Mar 25, 2024
We currently have two `Host` types. One in the `hostdb` package and one in the `api` package. Merging these removes unnecessary nesting and cleans up our API interfaces since we should exclusively return types from the `api` package. The `hostdb` package is now left with announcements stuff, which will be removed by `its-happening` after which we can remove the `hostdb` package entirely.
ChrisSchinnerl
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR gets rid of the contractor cache. It stores the host checks in the bus and uses those when performing contract checks. To do so I extended search hosts with the ability to filter on usability and autopilot ID.
Closes #1034