Update logging config to allow for more control over loggers #1071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisSchinnerl
force-pushed
the
chris/update-logger-config
branch
from
14e4283 to
a2f1e2b
Compare
ChrisSchinnerl
force-pushed
the
chris/update-logger-config
branch
from
6a4b050 to
46da673
Compare
n8maninger
reviewed
Mar 18, 2024
peterjan
requested changes
Mar 20, 2024
peterjan
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the config to be similar to
hostds to give more fine-grained control to the user.Considering that our logging right now (except for the database) defaults to "DEBUG" and I don't think that's what we actually want, I changed the default log level to "INFO" while making sure everything logged right now using
Debugis usingInfoto keep it getting logged for now. That should allow us to useDebugmore freely since it won't affect the default experience of users. Later we can think about whether we want to lower the log level of some of the existing logging to "DEBUG" but imo we have been logging pretty sparingly so far.Closes #1017