-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use WithContext to respect the contexts passed down to the SQL store #1057
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ngl after our last context refactor this is making me quite nervous. Did you run it for a bit to see nothing unexpected happens? Like db txns getting aborted because we messed up some contexts?
No, that's kind of what I think it's a pretty good change actually because there are likely cases where browsers cancel a request while our database engine is still processing the request and there's nothing cancelling that out. This should do that I believe. I don't mind running it on areq for a while before merging it maybe? This PR also includes the |
I'm not saying it's a bad change but this is prone to similar issues as |
Yeah I don't mind at all, it ran overnight on |
No description provided.