stores: check if we are using MySQL

SiaFoundation · Feb 19, 2024 · f02353f · f02353f
1 parent d3b879f
commit f02353f
Show file tree

Hide file tree

Showing 3 changed files with 28 additions and 25 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -43,10 +43,10 @@ jobs:
             autopilot
             bus bus/client
             worker worker/client
-      - name: Test
-        uses: n8maninger/action-golang-test@v1
-        with:
-          args: "-race;-short"
+      # - name: Test
+      #   uses: n8maninger/action-golang-test@v1
+      #   with:
+      #     args: "-race;-short"
       - name: Test Stores - MySQL
         if: matrix.os == 'ubuntu-latest'
         uses: n8maninger/action-golang-test@v1
@@ -57,20 +57,20 @@ jobs:
         with:
           package: "./stores"
           args: "-failfast;-race;-tags=testing;-timeout=30m"
-      - name: Test Integration
-        uses: n8maninger/action-golang-test@v1
-        with:
-          package: "./internal/testing/..."
-          args: "-failfast;-race;-tags=testing;-timeout=30m"
-      - name: Test Integration - MySQL
-        if: matrix.os == 'ubuntu-latest'
-        uses: n8maninger/action-golang-test@v1
-        env:
-          RENTERD_DB_URI: 127.0.0.1:3800
-          RENTERD_DB_USER: root
-          RENTERD_DB_PASSWORD: test
-        with:
-          package: "./internal/testing/..."
-          args: "-failfast;-race;-tags=testing;-timeout=30m"
+      # - name: Test Integration
+      #   uses: n8maninger/action-golang-test@v1
+      #   with:
+      #     package: "./internal/testing/..."
+      #     args: "-failfast;-race;-tags=testing;-timeout=30m"
+      # - name: Test Integration - MySQL
+      #   if: matrix.os == 'ubuntu-latest'
+      #   uses: n8maninger/action-golang-test@v1
+      #   env:
+      #     RENTERD_DB_URI: 127.0.0.1:3800
+      #     RENTERD_DB_USER: root
+      #     RENTERD_DB_PASSWORD: test
+      #   with:
+      #     package: "./internal/testing/..."
+      #     args: "-failfast;-race;-tags=testing;-timeout=30m"
       - name: Build
         run: go build -o bin/ ./cmd/renterd
diff --git a/stores/slabbuffer_test.go b/stores/slabbuffer_test.go
@@ -12,6 +12,10 @@ func TestRecordAppendToCompletedBuffer(t *testing.T) {
 	ss := newTestSQLStore(t, defaultTestSQLStoreConfig)
 	defer ss.Close()
 
+	if isSQLite(ss.db) {
+		t.Fatal("we're still using SQLite")
+	}
+
 	completionThreshold := int64(1000)
 	mgr, err := newSlabBufferManager(ss.SQLStore, completionThreshold, t.TempDir())
 	if err != nil {

diff --git a/stores/sql_test.go b/stores/sql_test.go
@@ -48,12 +48,11 @@ type testSQLStore struct {
 }
 
 type testSQLStoreConfig struct {
-	dbURI         string
-	dbUser        string
-	dbPassword    string
-	dbName        string
-	dbMetricsName string
-
+	dbURI           string
+	dbUser          string
+	dbPassword      string
+	dbName          string
+	dbMetricsName   string
 	dir             string
 	persistent      bool
 	skipMigrate     bool