Skip to content

Commit

Permalink
migrator: don't interrupt migrations when refresh fails
Browse files Browse the repository at this point in the history
  • Loading branch information
ChrisSchinnerl committed Jul 30, 2024
1 parent f07554a commit 86a2bc2
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
2 changes: 1 addition & 1 deletion autopilot/alerts.go
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ func newRefreshHealthFailedAlert(err error) alerts.Alert {
Severity: alerts.SeverityCritical,
Message: "Health refresh failed",
Data: map[string]interface{}{
"migrationsInterrupted": true,
"migrationsInterrupted": false,
"error": err.Error(),
},
Timestamp: time.Now(),
Expand Down
1 change: 0 additions & 1 deletion autopilot/migrator.go
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,6 @@ OUTER:
if err := b.RefreshHealth(m.ap.shutdownCtx); err != nil {
m.ap.RegisterAlert(m.ap.shutdownCtx, newRefreshHealthFailedAlert(err))
m.logger.Errorf("failed to recompute cached health before migration: %v", err)
return
}
m.logger.Infof("recomputed slab health in %v", time.Since(start))

Expand Down

0 comments on commit 86a2bc2

Please sign in to comment.