stores: change bCurrency type to BigEndian (#991)

SiaFoundation · Feb 22, 2024 · 414090b · 414090b
1 parent 9cdcd60
commit 414090b
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 9 deletions.
diff --git a/stores/metadata_test.go b/stores/metadata_test.go
@@ -4326,13 +4326,13 @@ func TestTypeCurrency(t *testing.T) {
 			cmp: "=",
 		},
 		{
-			a:   types.NewCurrency(0, math.MaxUint64),
-			b:   types.NewCurrency(math.MaxUint64, 0),
+			a:   types.NewCurrency(math.MaxUint64, 0),
+			b:   types.NewCurrency(0, math.MaxUint64),
 			cmp: "<",
 		},
 		{
-			a:   types.NewCurrency(math.MaxUint64, 0),
-			b:   types.NewCurrency(0, math.MaxUint64),
+			a:   types.NewCurrency(0, math.MaxUint64),
+			b:   types.NewCurrency(math.MaxUint64, 0),
 			cmp: ">",
 		},
 	}
@@ -4342,7 +4342,13 @@ func TestTypeCurrency(t *testing.T) {
 		if err != nil {
 			t.Fatal(err)
 		} else if !result {
-			t.Fatal("unexpected result", result)
+			t.Fatalf("unexpected result %v for %v %v %v", result, test.a, test.cmp, test.b)
+		} else if test.cmp == "<" && test.a.Cmp(test.b) >= 0 {
+			t.Fatal("invalid result")
+		} else if test.cmp == ">" && test.a.Cmp(test.b) <= 0 {
+			t.Fatal("invalid result")
+		} else if test.cmp == "=" && test.a.Cmp(test.b) != 0 {
+			t.Fatal("invalid result")
 		}
 	}
 

diff --git a/stores/types.go b/stores/types.go
@@ -354,15 +354,15 @@ func (sc *bCurrency) Scan(src any) error {
 		return fmt.Errorf("cannot scan %d bytes to Currency", len(buf))
 	}
 
-	sc.Lo = binary.LittleEndian.Uint64(buf[:8])
-	sc.Hi = binary.LittleEndian.Uint64(buf[8:])
+	sc.Hi = binary.BigEndian.Uint64(buf[:8])
+	sc.Lo = binary.BigEndian.Uint64(buf[8:])
 	return nil
 }
 
 // Value implements the driver.Valuer interface.
 func (sc bCurrency) Value() (driver.Value, error) {
 	buf := make([]byte, 16)
-	binary.LittleEndian.PutUint64(buf[:8], sc.Lo)
-	binary.LittleEndian.PutUint64(buf[8:], sc.Hi)
+	binary.BigEndian.PutUint64(buf[:8], sc.Hi)
+	binary.BigEndian.PutUint64(buf[8:], sc.Lo)
 	return buf, nil
 }