Merge pull request #223 from SiaFoundation/nate/add-sector-context

Add root to read sector error context

host/storage/storage.go

@@ -831,7 +831,7 @@ func (vm *VolumeManager) Read(root types.Hash256) (*[rhp2.SectorSize]byte, error
 	// Cache miss, read from disk
 	loc, release, err := vm.vs.SectorLocation(root)
 	if err != nil {
-		return nil, fmt.Errorf("failed to locate sector %v: %w", root, err)
+		return nil, fmt.Errorf("failed to locate sector: %w", err)
 	}
 	defer release()
 
@@ -844,7 +844,7 @@ func (vm *VolumeManager) Read(root types.Hash256) (*[rhp2.SectorSize]byte, error
 	vm.mu.Unlock()
 	sector, err := v.ReadSector(loc.Index)
 	if err != nil {
-		return nil, fmt.Errorf("failed to read sector %v: %w", root, err)
+		return nil, fmt.Errorf("failed to read sector data: %w", err)
 	}
 
 	// Add sector to cache

rhp/v3/execute.go

@@ -189,7 +189,7 @@ func (pe *programExecutor) executeHasSector(instr *rhp3.InstrHasSector) ([]byte,
 	var has bool
 	release, err := pe.storage.LockSector(root)
 	if err != nil && !errors.Is(err, storage.ErrSectorNotFound) {
-		return nil, nil, fmt.Errorf("failed to locate sector: %w", err)
+		return nil, nil, fmt.Errorf("failed to locate sector %q: %w", root, err)
 	} else if err == nil {
 		has = true
 		pe.releaseFuncs = append(pe.releaseFuncs, release)
@@ -275,7 +275,7 @@ func (pe *programExecutor) executeReadSector(instr *rhp3.InstrReadSector, log *z
 
 	sector, err := pe.storage.Read(root)
 	if err != nil {
-		return nil, nil, fmt.Errorf("failed to read sector: %w", err)
+		return nil, nil, fmt.Errorf("failed to read sector %q: %w", root, err)
 	}
 
 	// if no proof was requested, return the data