Add indices endpoint #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
n8maninger
force-pushed
the
nate/add-indices-endpoint
branch
from
2a57c5c to
8b47464
Compare
chris124567
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into a major performance degredation when retrieving blocks after merging #88. Noticed an index was missing. This adds the missing index, but also refactors it a bit.(Merged in #91)There is a transaction on mainnet that has been included in 14,000 blocks.
exploredtakes a long time to load the block with the transaction even with the index. Sia Central crashes when trying. This brings up an interesting question of how to proceed if a transaction were to be included in every block?One option is arbitrarily capping the indices a transaction will return. This is fine, but it may be a requirement to know every block a transaction is included in. The preferred solution is to split it into two endpoints. Data on the chain indice endpoint is capped by the usual limit and offset pagination parameters to keep responses reasonable.