Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store transactions #2

Merged
merged 22 commits into from
Jan 13, 2024
Merged

Store transactions #2

merged 22 commits into from
Jan 13, 2024

Conversation

chris124567
Copy link
Member

Store transactions and their ArbitraryData. Adds API endpoint for retrieving a transaction by ID and a bulk endpoint as well.

@chris124567 chris124567 requested review from n8maninger and ChrisSchinnerl and removed request for n8maninger January 9, 2024 19:47
n8maninger
n8maninger requested changes Jan 9, 2024
View reviewed changes
persist/sqlite/query.go Outdated Show resolved Hide resolved
persist/sqlite/query.go Outdated Show resolved Hide resolved
persist/sqlite/query.go Outdated Show resolved Hide resolved
persist/sqlite/query.go Outdated Show resolved Hide resolved
persist/sqlite/txn.go Outdated Show resolved Hide resolved
ChrisSchinnerl
ChrisSchinnerl requested changes Jan 10, 2024
View reviewed changes
api/server.go Outdated Show resolved Hide resolved
api/server.go Outdated Show resolved Hide resolved
api/server.go Outdated Show resolved Hide resolved
persist/sqlite/query.go Outdated Show resolved Hide resolved
persist/sqlite/query.go Outdated Show resolved Hide resolved
persist/sqlite/query.go Outdated Show resolved Hide resolved
persist/sqlite/txn.go Outdated Show resolved Hide resolved
persist/sqlite/txn.go Outdated Show resolved Hide resolved
n8maninger
n8maninger requested changes Jan 12, 2024
View reviewed changes
persist/sqlite/init.sql Outdated Show resolved Hide resolved
persist/sqlite/init.sql Outdated Show resolved Hide resolved
persist/sqlite/query.go Outdated Show resolved Hide resolved
persist/sqlite/query.go Outdated Show resolved Hide resolved
persist/sqlite/query.go Outdated Show resolved Hide resolved
persist/sqlite/query.go Outdated Show resolved Hide resolved
persist/sqlite/query.go Outdated Show resolved Hide resolved
persist/sqlite/query.go Outdated Show resolved Hide resolved
@chris124567
Copy link
Member Author

Thank you Nate. Now that we have this basic structure implementing the remaining transaction fields shouldn't be too bad.

Anyone have any thoughts on removing Transaction from the Store and Explorer interface given that we now have a Transactions function? Or we could leave it in the Explorer but implement it in terms of the underlying store's Transactions. Or just leave it.

@n8maninger
Copy link
Member

Thank you Nate. Now that we have this basic structure implementing the remaining transaction fields shouldn't be too bad.

Anyone have any thoughts on removing Transaction from the Store and Explorer interface given that we now have a Transactions function? Or we could leave it in the Explorer but implement it in terms of the underlying store's Transactions. Or just leave it.

I think it’s fine to remove Transaction from both

n8maninger
n8maninger requested changes Jan 12, 2024
View reviewed changes
api/server.go Show resolved Hide resolved
@n8maninger n8maninger merged commit cdaad98 into master Jan 13, 2024
6 checks passed
@n8maninger n8maninger deleted the add-txn branch January 13, 2024 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n8maninger n8maninger n8maninger requested changes

@ChrisSchinnerl ChrisSchinnerl ChrisSchinnerl requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chris124567 @n8maninger @ChrisSchinnerl