Fix bug in host scanning #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8maninger
force-pushed
the
fix-last-announcement-update
branch
from
2e04421 to
8179abe
Compare
n8maninger
requested changes
Nov 21, 2024
peterjan
reviewed
Nov 22, 2024
peterjan
reviewed
Nov 22, 2024
… in a transaction and then mining a block with that txn) rather than through unexported addHosts method, simplify query used in addHosts because we only need to update lastAnnouncement and the net addresses for that host, use a separate query for unsuccessful scans and successful scans in addHostScans
n8maninger
requested changes
Nov 25, 2024
|
OK I think this can be merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
last_announcementcolumn would not be updated after it was initially set. Because we only scan hosts wherelast_announcementis from the past 90 days, this meant that only new hosts announced in the past 3 months would be returned byHostsForScanningand thus scanned. This caused us to miss hosts that were announced for the first time more than 90 days ago but were still active. Add checks toTestScanto catch this in the future.addHoststo not overwrite the host settings we got from a previous successful scan in the event of a failed scan. Add check toTestScanto ensure this does not happen.