Make contract confirmation index NOT NULL #142
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike with proofs or resolutions, a contract is guaranteed to be confirmed once it is in the database. Previously this data was stored as nullable to make it convenient to update alongside resolution index / resolution transaction ID in
updateFileContractIndices
/updateV2FileContractIndices
. We also split the the chain index into separate fields, i.e.So that we can have a direct reference to the block.
Note: Base of this branch is v2 to avoid complicated rebasing once that's merged but it's not really a v2 feature so I don't think it needs to be merged into there.