Add v2 file contract resolutions #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris124567
force-pushed
the
add-v2-file-contract-resolutions
branch
2 times, most recently
from
4a5c25c to
cdd81a8
Compare
peterjan
reviewed
Nov 12, 2024
peterjan
reviewed
Nov 12, 2024
chris124567
force-pushed
the
add-v2-file-contract-resolutions
branch
from
5976d4f to
fe702e3
Compare
chris124567
force-pushed
the
add-v2-file-contract-resolutions
branch
from
fe702e3 to
7e5afd1
Compare
|
Should be OK to merge |
ChrisSchinnerl
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the only v2 transaction data we are not presently storing. I will try to clean up
fillV2TransactionFileContractResolutionsand cut down the number of queries. We now also store the chain index element for every block which is needed for storage proofs.