Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ContractRevisions return type for consistency #108

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

chris124567
Copy link
Member

@chris124567 chris124567 commented Oct 3, 2024

All of the other contract functions return explorer.FileContracts so it is easier for API consumers if we use those instead in ContractRevisions, even though we will be returning redundant data for ProofIndex, ConfirmationIndex, etc.

@chris124567 chris124567 requested a review from n8maninger October 3, 2024 16:35
@n8maninger n8maninger merged commit 1ff58d9 into master Oct 3, 2024
9 checks passed
@n8maninger n8maninger deleted the change-revision-type branch October 3, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants