New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: maker contructor arguments #103

Merged

n8maninger merged 1 commit into master from 12-10-fix_maker_contructor_arguments

Dec 10, 2024

Member

alexfreska commented Dec 10, 2024 •

edited

Loading

Noticed the macos RELEASES.json was not being updated, the issue is that the maker constructor arguments look like: MakerSquirrel(configOrConfigFetcher?, platformsToMakeOn?) docs This PR fixes the issue so the config params are properly applied.

Follow up to previous changes for #99

Member Author

alexfreska commented Dec 10, 2024

fix: maker contructor arguments #103 👈 (View in Graphite)
master

This stack of pull requests is managed by Graphite. Learn more about stacking.


          fix: maker contructor arguments

cc55d3b

alexfreska force-pushed the 12-10-fix_maker_contructor_arguments branch from a74c2bc to cc55d3b Compare

December 10, 2024 23:18

alexfreska marked this pull request as ready for review

December 10, 2024 23:20

alexfreska requested a review from n8maninger

December 10, 2024 23:20

graphite-app bot assigned alexfreska

n8maninger approved these changes

View reviewed changes

n8maninger merged commit 4838146 into master

18 checks passed

n8maninger deleted the 12-10-fix_maker_contructor_arguments branch

December 10, 2024 23:34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet