Skip to content

Commit

Permalink
add s3 bucket secrets
Browse files Browse the repository at this point in the history
  • Loading branch information
alexfreska committed Jan 30, 2024
1 parent eb37b08 commit eab1722
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 4 deletions.
4 changes: 0 additions & 4 deletions .github/workflows/pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,6 @@ jobs:
run: yarn workspace ${{ matrix.app }} build
shell: bash
- name: Package executable bundles, make distributables
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: yarn workspace ${{ matrix.app }} make
shell: bash
windows:
Expand All @@ -91,8 +89,6 @@ jobs:
run: yarn workspace ${{ matrix.app }} build
shell: bash
- name: Package executable bundles, sign and notarize, make distributables
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: |
yarn workspace ${{ matrix.app }} make
# #TODO: probably not correct
Expand Down
6 changes: 6 additions & 0 deletions .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,8 @@ jobs:
APPLE_API_KEY: ${{ secrets.APPLE_API_KEY }}
APPLE_API_ISSUER: ${{ secrets.APPLE_API_ISSUER }}
APPLE_API_KEY_PATH: ${{ env.APPLE_API_KEY_PATH }}
BUCKET_ACCESS_KEY_ID: ${{ secrets.BUCKET_ACCESS_KEY_ID }}
BUCKET_SECRET_ACCESS_KEY: ${{ secrets.BUCKET_SECRET_ACCESS_KEY }}
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: yarn workspace ${{ matrix.app }} publish
shell: bash
Expand All @@ -73,6 +75,8 @@ jobs:
shell: bash
- name: Package executable bundles, make and publish distributables
env:
BUCKET_ACCESS_KEY_ID: ${{ secrets.BUCKET_ACCESS_KEY_ID }}
BUCKET_SECRET_ACCESS_KEY: ${{ secrets.BUCKET_SECRET_ACCESS_KEY }}
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: yarn workspace ${{ matrix.app }} publish
shell: bash
Expand All @@ -94,6 +98,8 @@ jobs:
shell: bash
- name: Package executable bundles, sign and notarize, make and publish distributables
env:
BUCKET_ACCESS_KEY_ID: ${{ secrets.BUCKET_ACCESS_KEY_ID }}
BUCKET_SECRET_ACCESS_KEY: ${{ secrets.BUCKET_SECRET_ACCESS_KEY }}
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: |
yarn workspace ${{ matrix.app }} publish
Expand Down

0 comments on commit eab1722

Please sign in to comment.