fix: windows electron install

SiaFoundation · May 16, 2024 · 85e3762 · 85e3762
1 parent 3f50d27
commit 85e3762
Show file tree

Hide file tree

Showing 6 changed files with 13 additions and 8 deletions.
diff --git a/.github/workflows/pr.yml b/.github/workflows/pr.yml
@@ -13,6 +13,7 @@ jobs:
   mac:
     if: ${{ github.event_name == 'pull_request' && github.event.action != 'closed' }}
     strategy:
+      fail-fast: false
       matrix:
         app: [hostd, renterd, walletd]
     runs-on: macos-latest
@@ -21,7 +22,7 @@ jobs:
       - name: Setup
         uses: ./.github/actions/setup
         with:
-          node_version: 20.10.0
+          node_version: 18
       - name: Setup signing
         env:
           APPLE_CERT_ID: ${{ secrets.APPLE_CERT_ID }}
@@ -74,6 +75,7 @@ jobs:
   linux:
     if: ${{ github.event_name == 'pull_request' && github.event.action != 'closed' }}
     strategy:
+      fail-fast: false
       matrix:
         app: [hostd, renterd, walletd]
     runs-on: ubuntu-latest
@@ -82,7 +84,7 @@ jobs:
       - name: Setup
         uses: ./.github/actions/setup
         with:
-          node_version: 20.10.0
+          node_version: 18
       - name: Lint
         run: yarn workspace ${{ matrix.app }} lint
         shell: bash
@@ -100,6 +102,7 @@ jobs:
   windows:
     if: ${{ github.event_name == 'pull_request' && github.event.action != 'closed' }}
     strategy:
+      fail-fast: false
       matrix:
         app: [hostd, renterd, walletd]
     runs-on: windows-latest
@@ -108,7 +111,7 @@ jobs:
       - name: Setup
         uses: ./.github/actions/setup
         with:
-          node_version: 20.10.0
+          node_version: 18
       - name: Setup signing
         run: dotnet tool install --global AzureSignTool
       - name: Lint

diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml
@@ -18,7 +18,7 @@ jobs:
       - name: Setup
         uses: ./.github/actions/setup
         with:
-          node_version: 20.10.0
+          node_version: 18
       - name: Setup signing
         env:
           APPLE_CERT_ID: ${{ secrets.APPLE_CERT_ID }}
@@ -88,7 +88,7 @@ jobs:
       - name: Setup
         uses: ./.github/actions/setup
         with:
-          node_version: 20.10.0
+          node_version: 18
       - name: Build
         uses: nick-fields/retry@v3
         with:
@@ -124,7 +124,7 @@ jobs:
       - name: Setup
         uses: ./.github/actions/setup
         with:
-          node_version: 20.10.0
+          node_version: 18
       - name: Setup signing
         run: dotnet tool install --global AzureSignTool
       - name: Build

diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -15,7 +15,7 @@ jobs:
       - name: Setup
         uses: ./.github/actions/setup
         with:
-          node_version: 20.10.0
+          node_version: 18
       - name: Update release pull request or publish
         id: changesets
         uses: changesets/action@v1

diff --git a/.yarn/install-state.gz b/.yarn/install-state.gz
diff --git a/renterd/package.json b/renterd/package.json
@@ -82,6 +82,7 @@
     "eslint-config-next": "13.3.0",
     "globals": "^15.2.0",
     "next": "13.5.2",
+    "phantomjs-prebuilt": "^2.1.16",
     "postcss": "^8.4.31",
     "rimraf": "^3.0.2",
     "typescript": "5.0.3",

diff --git a/yarn.lock b/yarn.lock
@@ -11474,7 +11474,7 @@ __metadata:
   languageName: node
   linkType: hard
 
-"phantomjs-prebuilt@npm:^2.1.14":
+"phantomjs-prebuilt@npm:^2.1.14, phantomjs-prebuilt@npm:^2.1.16":
   version: 2.1.16
   resolution: "phantomjs-prebuilt@npm:2.1.16"
   dependencies:
@@ -12321,6 +12321,7 @@ __metadata:
     globals: "npm:^15.2.0"
     js-yaml: "npm:^4.1.0"
     next: "npm:13.5.2"
+    phantomjs-prebuilt: "npm:^2.1.16"
     postcss: "npm:^8.4.31"
     react: "npm:^18.2.0"
     react-dom: "npm:18.2.0"