Skip to content

Commit

Permalink
ci: windows signing
Browse files Browse the repository at this point in the history
  • Loading branch information
alexfreska committed May 20, 2024
1 parent c429ab8 commit 52efe74
Showing 1 changed file with 6 additions and 5 deletions.
11 changes: 6 additions & 5 deletions .github/workflows/pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -139,9 +139,10 @@ jobs:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: Package executable bundles, sign and notarize, make distributables
run: |
npm run make --arch=x64
# #TODO: probably not correct
# APP_PATH="out/${{ matrix.app }}-win32-x64/${{ matrix.app }}.app"
# BINARY_PATH="$APP_PATH/Contents/Windows/${{ matrix.app }}.exe"
# azuresigntool sign -kvu "${{ secrets.AZURE_KEY_VAULT_URI }}" -kvi "${{ secrets.AZURE_CLIENT_ID }}" -kvt "${{ secrets.AZURE_TENANT_ID }}" -kvs "${{ secrets.AZURE_CLIENT_SECRET }}" -kvc ${{ secrets.AZURE_CERT_NAME }} -tr http://timestamp.digicert.com -v $BINARY_PATH
npm run package --arch=x64
ls -lh out/${{ matrix.app }}-win32-x64
ls -lh out/${{ matrix.app }}-win32-x64/resources
BINARY_PATH="out/${{ matrix.app }}-win32-x64/${{ matrix.app }}.exe"
azuresigntool sign -kvu "${{ secrets.AZURE_KEY_VAULT_URI }}" -kvi "${{ secrets.AZURE_CLIENT_ID }}" -kvt "${{ secrets.AZURE_TENANT_ID }}" -kvs "${{ secrets.AZURE_CLIENT_SECRET }}" -kvc ${{ secrets.AZURE_CERT_NAME }} -tr http://timestamp.digicert.com -v $BINARY_PATH
npm run make --arch=x64 --skip-package
shell: bash

0 comments on commit 52efe74

Please sign in to comment.