Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for v2 transactions to Single Address Wallet #54

Merged
merged 8 commits into from
May 29, 2024
Merged

Add support for v2 transactions to Single Address Wallet #54

merged 8 commits into from
May 29, 2024

Conversation

n8maninger
Copy link
Member

@n8maninger n8maninger commented May 26, 2024 •
edited
Loading

Adds support for v2 events and constructing v2 transactions to the single address wallet.

Closes #49

@n8maninger n8maninger force-pushed the nate/single-wallet-v2 branch from 9a881ac to 67582e2 Compare May 26, 2024 20:59
@n8maninger n8maninger marked this pull request as ready for review May 27, 2024 16:59
@n8maninger n8maninger force-pushed the nate/single-wallet-v2 branch from 03c706d to 8d95e1c Compare May 27, 2024 17:28
@n8maninger n8maninger requested a review from lukechampine May 27, 2024 17:52
peterjan
peterjan previously approved these changes May 28, 2024
View reviewed changes
Copy link
Member

@peterjan peterjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid 👍 one nit I considered was that I preferred "source" over "type" but other than that it LGTM

peterjan
peterjan reviewed May 28, 2024
View reviewed changes
wallet/events.go Outdated Show resolved Hide resolved
peterjan
peterjan reviewed May 28, 2024
View reviewed changes
testutil/wallet.go Outdated Show resolved Hide resolved
peterjan
peterjan reviewed May 28, 2024
View reviewed changes
wallet/update.go Outdated Show resolved Hide resolved
ChrisSchinnerl
ChrisSchinnerl previously approved these changes May 28, 2024
View reviewed changes
wallet/update.go Show resolved Hide resolved
wallet/update.go Show resolved Hide resolved
@n8maninger n8maninger dismissed stale reviews from ChrisSchinnerl and peterjan via f2f05b8 May 28, 2024 16:21
@n8maninger n8maninger force-pushed the nate/single-wallet-v2 branch from f2f05b8 to a3687a9 Compare May 28, 2024 16:44
@n8maninger n8maninger merged commit 912fbdd into master May 29, 2024
8 checks passed
@n8maninger n8maninger deleted the nate/single-wallet-v2 branch May 29, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisSchinnerl ChrisSchinnerl ChrisSchinnerl approved these changes

@lukechampine lukechampine lukechampine approved these changes

@peterjan peterjan peterjan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for V2 types to SingleAddressWallet
4 participants
@n8maninger @peterjan @lukechampine @ChrisSchinnerl