syncer: always allow manual peer connections

syncer/syncer.go

@@ -526,7 +526,11 @@ func (s *Syncer) peerLoop(ctx context.Context) error {
 		for _, p := range candidates {
 			if numOutbound() >= s.config.MaxOutboundPeers {
 				break
+			} else if err := s.allowConnect(ctx, p, false); err != nil {
+				log.Debug("rejected outbound peer", zap.String("peer", p), zap.Error(err))
+				break
 			}
+
 			ctx, cancel := context.WithTimeout(ctx, s.config.ConnectTimeout)
 			if _, err := s.Connect(ctx, p); err != nil {
 				log.Debug("connected to peer", zap.String("peer", p))
@@ -684,10 +688,6 @@ func (s *Syncer) Close() error {
 
 // Connect forms an outbound connection to a peer.
 func (s *Syncer) Connect(ctx context.Context, addr string) (*Peer, error) {
-	if err := s.allowConnect(ctx, addr, false); err != nil {
-		return nil, err
-	}
-
 	conn, err := (&net.Dialer{}).DialContext(ctx, "tcp", addr)
 	if err != nil {
 		return nil, err