Allow revisions to set MaxRevisionNumber #247
Merged
+7
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukechampine
force-pushed
the
max-revision
branch
from
9fde941 to
fa557a1
Compare
lukechampine
force-pushed
the
max-revision
branch
from
fa557a1 to
ba1e68d
Compare
n8maninger
changed the title
lukechampine
force-pushed
the
max-revision
branch
from
ba1e68d to
6f9994c
Compare
n8maninger
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MaxRevisionNumberno longer has any relevance to consensus (aside from preventing any further revisions). Previously it was used when resolving contracts, but that is not the case anymore. We might as well keep the constant around, though; removing it would be a breaking API change, and maybe there's a usecase for finalizing a contract without resolving it.