Fix renewal payout validation #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8maninger
commented
Dec 3, 2024
n8maninger
commented
Dec 3, 2024
peterjan
approved these changes
Dec 3, 2024
ChrisSchinnerl
approved these changes
Dec 3, 2024
lukechampine
reviewed
Dec 3, 2024
| return fmt.Errorf("file contract renewal %v changes renter public key", i) | ||
| } else if fc.HostPublicKey != renewal.NewContract.HostPublicKey { | ||
| return fmt.Errorf("file contract renewal %v changes host public key", i) | ||
| } |
There was a problem hiding this comment.
we could allow this though, right? I don't think it would be unsafe, since the whole renewal is validated using the old keys.
There was a problem hiding this comment.
well, we allow revisions to change the keys. Granted, I don't see a ton of utility there either; key rotation is really not as much of a thing as people assume. So I'd be ok disallowing it in both cases too -- just wanna be consistent.
lukechampine
reviewed
Dec 3, 2024
| Add(renewal.FinalHostOutput.Value).Add(renewal.HostRollover) | ||
| existingPayout := fc.RenterOutput.Value.Add(fc.HostOutput.Value) | ||
| if totalPayout != existingPayout { | ||
| return fmt.Errorf("file contract renewal %d renewal payout (%s) does not match existing contract payout %s", i, totalPayout, existingPayout) |
There was a problem hiding this comment.
error is a bit inconsistent with the others, which use (%d H). That might predate #146, so perhaps we should switch them all to %s now?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did not notice this until after trying to update coreutils with #238. The new renewal validation logic was checking the individual payout values against the parent file contract element. This does not account for the payouts changing in an unbroadcast revision. This changes the logic to check that the sum of the outputs is equal to the sum of the parent outputs. Also adds some additional validation tests.