types: Move complexity check to (SpendPolicy).Verify #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8maninger
force-pushed
the
large-policies
branch
from
055fe01 to
788be94
Compare
n8maninger
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same rationale as #234: this logic wasn't present in
UnmarshalJSON, leading to inconsistency.I also tweaked the behavior of
thresh.threshis supposed to require exactlynpolicies to be satisfied (so I suppose "threshold" is a bit of a misnomer), soopaqueis used to hide unsatisfied policies. ButVerifywas only checking thatpkandhpolicies were replaced withopaque;aboveandafterwere allowed to fail without causing the entire policy to fail. This isn't necessarily wrong -- and in fact, it's slightly more space-efficient -- but it feels inconsistent, and it's more ambiguous. I like how requiringopaqueforces you to be explicit about which sub-policies you're using (and also makes it obvious to the reader which sub-policies are being satisfied).