Skip to content

Add golangci-lint

Add golangci-lint #551

Triggered via pull request December 6, 2023 22:16
Status Failure
Total duration 36s
Artifacts

test.yml

on: pull_request
Matrix: test
Fit to window
Zoom out
Zoom in

Annotations

11 errors and 20 warnings
test (ubuntu-latest, 1.20)
issues found
test (ubuntu-latest, 1.21)
The job was canceled because "ubuntu-latest_1_20" failed.
test (ubuntu-latest, 1.21)
issues found
test (macos-latest, 1.21)
The job was canceled because "ubuntu-latest_1_20" failed.
test (macos-latest, 1.21)
The operation was canceled.
test (windows-latest, 1.21)
The job was canceled because "ubuntu-latest_1_20" failed.
test (windows-latest, 1.21)
The operation was canceled.
test (windows-latest, 1.20)
The job was canceled because "ubuntu-latest_1_20" failed.
test (windows-latest, 1.20)
The operation was canceled.
test (macos-latest, 1.20)
The job was canceled because "ubuntu-latest_1_20" failed.
test (macos-latest, 1.20)
The operation was canceled.
test (ubuntu-latest, 1.20): internal/smux/stream.go#L150
if-return: redundant if ...; err != nil check, just return error instead. (revive)
test (ubuntu-latest, 1.20): chain/db.go#L680
indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (revive)
test (ubuntu-latest, 1.20): gateway/gateway.go#L71
indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (revive)
test (ubuntu-latest, 1.20): types/encoding.go#L449
modifies-value-receiver: suspicious assignment to a by-value method receiver (revive)
test (ubuntu-latest, 1.20): types/currency.go#L245
modifies-value-receiver: suspicious assignment to a by-value method receiver (revive)
test (ubuntu-latest, 1.20): types/currency.go#L66
indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (revive)
test (ubuntu-latest, 1.20): types/policy.go#L116
modifies-value-receiver: suspicious assignment to a by-value method receiver (revive)
test (ubuntu-latest, 1.20): types/policy.go#L140
modifies-value-receiver: suspicious assignment to a by-value method receiver (revive)
test (ubuntu-latest, 1.20): types/policy.go#L215
modifies-value-receiver: suspicious assignment to a by-value method receiver (revive)
test (ubuntu-latest, 1.20): rhp/v3/registry.go#L97
unnecessary-stmt: omit unnecessary break at the end of case clause (revive)
test (ubuntu-latest, 1.21): internal/smux/stream.go#L150
if-return: redundant if ...; err != nil check, just return error instead. (revive)
test (ubuntu-latest, 1.21): types/encoding.go#L449
modifies-value-receiver: suspicious assignment to a by-value method receiver (revive)
test (ubuntu-latest, 1.21): types/policy.go#L116
modifies-value-receiver: suspicious assignment to a by-value method receiver (revive)
test (ubuntu-latest, 1.21): types/policy.go#L140
modifies-value-receiver: suspicious assignment to a by-value method receiver (revive)
test (ubuntu-latest, 1.21): types/policy.go#L215
modifies-value-receiver: suspicious assignment to a by-value method receiver (revive)
test (ubuntu-latest, 1.21): types/currency.go#L245
modifies-value-receiver: suspicious assignment to a by-value method receiver (revive)
test (ubuntu-latest, 1.21): types/currency.go#L66
indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (revive)
test (ubuntu-latest, 1.21): rhp/v3/registry.go#L97
unnecessary-stmt: omit unnecessary break at the end of case clause (revive)
test (ubuntu-latest, 1.21): chain/db.go#L680
indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (revive)
test (ubuntu-latest, 1.21): gateway/gateway.go#L71
indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (revive)