-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADD_GPIB #88
base: master
Are you sure you want to change the base?
ADD_GPIB #88
Conversation
…as described here: http://prologix.biz/downloads/PrologixGpibUsbManual-4.2.pdf This enables GPIB usage with basil.
@DavidLP Can you look at this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is a really usefull addition to be able to use GPIB with Linux. Thank you! Unfortunately the pyVISA community did not manage to add this GPIB adapter to its library. There is an open issue since more than 3 years, so I guess it makes sence to add it to BASIL.
After a quick look over your code I think it can be slightly simplified.
@@ -0,0 +1,53 @@ | |||
# |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I see it the only difference to the already existing VISA implementation is the query command. So one could simplify this module to:
class PrologixVisa(Visa):
def query(self, data):
self._resource.write("++auto 0")
self._resource.write(data)
return self._resource.query("++read eoi")
and it would do the same, no?
I am not sure if the write and read commands also need changes. Did you check?
# Device description for HP E3632A Powersupply. | ||
# set_ function expect a parameter, get_ function return a parameter. | ||
# Just the very basic commands are imlemented here. | ||
identifier : HEWLETT-PACKARD,E3632A,0,1.1-5.0-1.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The identifier does not have to be fully matched. So sometimes it is better to not specify minor firmware versions for compatibility. I guess HEWLETT-PACKARD,E3632A could be enough here?
ADD: This pull adds the support for the Prologix USB to GPIB controller as described here:
http://prologix.biz/downloads/PrologixGpibUsbManual-4.2.pdf
This enables GPIB usage with basil for linux