-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: FCM 알림 기능 #86
base: develop
Are you sure you want to change the base?
feat: FCM 알림 기능 #86
Conversation
# Conflicts: # spy.log # src/main/java/com/shy_polarbear/server/global/common/constants/BusinessLogicConstants.java # src/main/java/com/shy_polarbear/server/global/exception/ExceptionStatus.java
혹시 월요일에 리뷰해도 될까요,,,,,,,?🐸🐔🐰 |
넵 졸업전시 이후에 반영할거라 천천히 해주세유🦧 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
어제 전시는 잘 하셨나요~ 늦어서 죄송합니다~~ 캐롤 들으면서 보니까 코드 잘 봤습니다🎄🎁
@OneToMany(mappedBy = "receiver") | ||
private List<Notification> notificationList = new ArrayList<>(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
근데 '유저-알림' 관계를 양방향으로 하는 이유가 뭘까요??
확장성을 고려한 걸까요?
|
||
// 내 알림 리스트 조회 | ||
public List<NotificationResponse> getMyNotifications(Long userId) { | ||
List<Notification> notificationList = notificationRepository.findAllByReceiverId(1L); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
여기 1L인 이유가 있을까요~??
package com.shy_polarbear.server.domain.notification.model; | ||
|
||
enum NotificationReceiverType { | ||
COMMON, AUTHOR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
알림 받는 사람이 왜 받는지 쉽게 알게 하려고 enum 만드신거 맞죠!?
.post(RequestBody.create(message, MediaType.parse("application/json; charset=urf-8"))) | ||
.build(); | ||
|
||
try (Response response = okHttpClient.newCall(request).execute()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FirebaseMessaging.getInstance().sendAsync(fcmMessage).get();
이걸 사용할 수는 없는 건가요?? - fcm 잘 모르는 노을😅
📌 PR 요약
FCM 기능 구현했습니다..!
너무 늦었지만... 구현해둔게 아까워서 마무리했어요
조금 불안해서 졸업 전시 끝나고 머지하는게 좋을 것 같긴 합니다
🌱 작업한 내용
🌱 PR 포인트
📸 스크린샷
📮 관련 이슈