Executable editing utils #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shotgunosine
requested changes
Nov 4, 2024
| format='%(asctime)s - %(levelname)s - %(message)s') | ||
|
|
||
|
|
||
| def edit_app_worker_id(app_path: str, new_worker_id: str, output_app_path: Optional[str] = None) -> None: |
There was a problem hiding this comment.
I don't think the output_app_path should be optional in the version of this code included in the backend. I'd like to avoid the possibility of the base apps getting accidentally overwritten.
There was a problem hiding this comment.
I'd prefer not to include the executables in this repo.
There was a problem hiding this comment.
Do you think you could store the task version (maybe just the commit hash) in the executables themselves? Then we could include that version string in the app.ini file and have version checking and executable downloading from OSF happen in here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran pytests & it completed successfully on my machine, generating new app bundles with updated workerID values. I tried to generally follow the practices established within the project already. The base executables themselves will be updated as we move towards a final version. The executables included here should work but are by no means finalized versions.