Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi 👋
We started monitoring prominent Stylelint packages to ensure that we don't accidentally break things when rolling out new features.
We noticed that
@shopify/stylelint-plugin
was failing these tests for two reasons.It uses
--formatter=github
to have stable lint output that is easily testable.This formatter was deprecated and the deprecation warning alone was causing the tests to fail.
I've switched this to
--formatter=json
which should also give stable outcomes.There were also various fixes in Stylelint rules to the reported start and end positions.
This changed the expected outcome of one of the tests.