Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Stylelint to v16.9.0 #435

Closed
wants to merge 5 commits into from
Closed

Conversation

romainmenke
Copy link

@romainmenke romainmenke commented Sep 8, 2024

Hi 👋

We started monitoring prominent Stylelint packages to ensure that we don't accidentally break things when rolling out new features.

We noticed that @shopify/stylelint-plugin was failing these tests for two reasons.


  1. It uses --formatter=github to have stable lint output that is easily testable.
    This formatter was deprecated and the deprecation warning alone was causing the tests to fail.
    I've switched this to --formatter=json which should also give stable outcomes.

  2. There were also various fixes in Stylelint rules to the reported start and end positions.
    This changed the expected outcome of one of the tests.

@BPScott
Copy link
Member

BPScott commented Sep 9, 2024

Thanks @romainmenke, I've shipped an adjusted version of this in #436, based upon how I handled the github formatter deprecation in prettier/stylelint-prettier#367

@romainmenke
Copy link
Author

Cool! thanks 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants