Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing variable.other.object.property scope #581

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Add missing variable.other.object.property scope #581

merged 1 commit into from
Feb 8, 2024

Conversation

vinistock
Copy link
Member

We were missing this scope and then properties defined with #property were highlighted inconsistently.

@vinistock vinistock added the bugfix This pull request fixes a bug label Feb 7, 2024
@vinistock vinistock self-assigned this Feb 7, 2024
@vinistock vinistock requested a review from a team as a code owner February 7, 2024 20:09
@vinistock vinistock merged commit ec52189 into main Feb 8, 2024
4 checks passed
@vinistock vinistock deleted the vs/add_missing_property_scope branch February 8, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KaanOzkan KaanOzkan KaanOzkan approved these changes

@egiurleo egiurleo Awaiting requested review from egiurleo egiurleo was automatically assigned from Shopify/ruby-dev-exp

Assignees

@vinistock vinistock

Labels
bugfix This pull request fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vinistock @KaanOzkan