This repository has been archived by the owner on May 30, 2024. It is now read-only.
Use general middleware to report performance and crash telemetry #798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyw8
reviewed
Sep 21, 2023
andyw8
reviewed
Sep 21, 2023
andyw8
reviewed
Sep 21, 2023
vinistock
force-pushed
the
vs/general_middleware
branch
from
d81d5e0 to
4c1ae73
Compare
andyw8
approved these changes
Sep 21, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #571, Closes Shopify/ruby-lsp#1498
A new version of the LSP client package has been released including our general middleware contribution. We can finally move forward with removing our server telemetry and shifting to client only.
Implementation