Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add jruby to CI #688

Closed
wants to merge 1 commit into from
Closed

Add jruby to CI #688

wants to merge 1 commit into from

Conversation

andyw8
Copy link
Contributor

@andyw8 andyw8 commented May 3, 2023 •
edited
Loading

Motivation

Implementation

Automated Tests

Manual Tests

@andyw8 andyw8 force-pushed the andyw8/jruby-ci branch from fc3e332 to 0e90196 Compare May 3, 2023 13:25
@andyw8 andyw8 mentioned this pull request May 3, 2023
Open
andyw8
andyw8 commented May 3, 2023
View reviewed changes
.github/workflows/ci.yml
@@ -8,7 +8,7 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest, macos-latest, windows-latest]
ruby: ["2.7", "3.0", "3.1", "3.2"]
ruby: ["2.7", "3.0", "3.1", "3.2", "jruby-head", "jruby"]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(checking with both but will remove jruby if jruby-head is passing).

@andyw8 andyw8 force-pushed the andyw8/jruby-ci branch from 0e90196 to 5381da2 Compare May 3, 2023 13:34
@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2023 •
edited
Loading 

Benchmark results in seconds (slowest at top)

          textDocument/completion average: 0.314948 std_dev: 0.007453
          textDocument/diagnostic average: 0.05309 std_dev: 0.011326
      textDocument/selectionRange average: 0.004099 std_dev: 0.000562
        textDocument/foldingRange average: 0.0019 std_dev: 0.000399
   textDocument/documentHighlight average: 0.001726 std_dev: 0.00029
 textDocument/semanticTokens/full average: 0.001034 std_dev: 0.000282
        textDocument/documentLink average: 0.001019 std_dev: 0.000273
      textDocument/documentSymbol average: 0.000988 std_dev: 0.000161
textDocument/semanticTokens/range average: 0.000732 std_dev: 0.000147
               codeAction/resolve average: 0.000705 std_dev: 0.000192
               textDocument/hover average: 0.000659 std_dev: 0.000374
            textDocument/codeLens average: 0.000582 std_dev: 0.000111
           textDocument/inlayHint average: 0.000396 std_dev: 7.5e-05
    textDocument/onTypeFormatting average: 0.000123 std_dev: 8.0e-05
          textDocument/formatting average: 6.9e-05 std_dev: 0.000189
          textDocument/codeAction average: 3.9e-05 std_dev: 3.9e-05


================================================================================
Comparison with main branch:

 textDocument/semanticTokens/full unchanged
textDocument/semanticTokens/range unchanged
      textDocument/documentSymbol unchanged
        textDocument/foldingRange unchanged
          textDocument/formatting unchanged
          textDocument/diagnostic unchanged
        textDocument/documentLink unchanged
           textDocument/inlayHint unchanged
      textDocument/selectionRange unchanged
   textDocument/documentHighlight unchanged
               textDocument/hover unchanged
          textDocument/codeAction unchanged
    textDocument/onTypeFormatting unchanged
               codeAction/resolve unchanged
          textDocument/completion unchanged
            textDocument/codeLens unchanged

@andyw8 andyw8 closed this May 3, 2023
@andyw8 andyw8 changed the title WIP: Add jruby to CI Add jruby to CI May 3, 2023
@greatscotty greatscotty deleted the andyw8/jruby-ci branch February 9, 2024 21:18
vinistock pushed a commit that referenced this pull request Feb 28, 2024
@github-actions
Merge pull request #688 from Shopify/dependabot/npm_and_yarn/types/no…
06a8c01 
…de-20.4.1

Bump @types/node from 20.3.2 to 20.4.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@andyw8