Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Show Output Channel command for VSCode extension #2986

Merged
merged 3 commits into from
Dec 20, 2024
Merged

Add Show Output Channel command for VSCode extension #2986

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
73b18f3
Add Show Output Channel command for VSCode extension
timkooi-jobber Dec 13, 2024
5ff324f
Fix capitalization and use LOG_CHANNEL for output
timkooi-jobber Dec 17, 2024
8ec1845
Merge branch 'main' into vscode-show-output-channel
andyw8 Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions vscode/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,11 @@
"command": "rubyLsp.migrateLaunchConfiguration",
"title": "Migrate launch.json configurations from rdbg to ruby_lsp",
"category": "Ruby LSP"
},
{
"command": "rubyLsp.showOutput",
"title": "Show output channel",
"category": "Ruby LSP"
}
],
"configuration": {
Expand Down
1 change: 1 addition & 0 deletions vscode/src/common.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ export enum Command {
NewMinitestFile = "rubyLsp.newMinitestFile",
CollectRubyLspInfo = "rubyLsp.collectRubyLspInfo",
StartServerInDebugMode = "rubyLsp.startServerInDebugMode",
ShowOutput = "rubyLsp.showOutput",
MigrateLaunchConfiguration = "rubyLsp.migrateLaunchConfiguration",
}

Expand Down
3 changes: 3 additions & 0 deletions vscode/src/rubyLsp.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -597,6 +597,9 @@
},
),
);
vscode.commands.registerCommand(Command.ShowOutput, async () => {
LOG_CHANNEL.show();
});
vscode.commands.registerCommand(
Command.MigrateLaunchConfiguration,
async () => {
Expand All @@ -623,7 +626,7 @@
delete newConfig.useBundler;

const command = (newConfig.command || "").replace(
"${workspaceRoot}/",

Check warning on line 629 in vscode/src/rubyLsp.ts

View workflow job for this annotation

GitHub Actions / lint_node 

Unexpected template string expression
"",
);
const script = newConfig.script || "";
Expand Down
Loading