Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid stubbing File.read to prevent flaky tests #2980

Merged

Conversation

vinistock
Copy link
Member

@vinistock vinistock commented Dec 12, 2024

Motivation

This test is flaky because sometimes threads switch and something else tries to invoke File.read. Instead of stubbing it, we can just create the expected file to avoid the flakiness.

@vinistock vinistock added the chore Chore task label Dec 12, 2024 — with Graphite App
@vinistock vinistock requested a review from andyw8 December 12, 2024 19:17
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@vinistock vinistock requested a review from st0012 December 12, 2024 19:17
@vinistock vinistock marked this pull request as ready for review December 12, 2024 19:18
@vinistock vinistock requested a review from a team as a code owner December 12, 2024 19:18
@vinistock vinistock merged commit d244ad2 into main Dec 12, 2024
36 checks passed
Copy link
Member Author

Merge activity

  • Dec 12, 2:39 PM EST: A user merged this pull request with Graphite.

@vinistock vinistock deleted the 12-12-avoid_stubbing_file.read_to_prevent_flaky_tests branch December 12, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Chore task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants