Locate targets under mutex lock #2976
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
added
bugfix
Graphite App
vinistock
force-pushed
the
12-11-locate_targets_under_mutex_lock
branch
from
006f5b1 to
6980656
Compare
st0012
reviewed
Dec 16, 2024
| @document = document | ||
| @position = T.let(position, T::Hash[Symbol, Integer]) | ||
| end | ||
|
|
||
| sig { override.returns(T.nilable(Interface::Range)) } | ||
| def perform | ||
| char_position = @document.create_scanner.find_char_position(@position) | ||
| char_position = @global_state.synchronize do | ||
| @document.create_scanner.find_char_position(@position) |
There was a problem hiding this comment.
Should we find a way to make the mutex mandatory when calling scanner? Like:
@document.create_scanner(@global_state.mutex).find_char_position(@position)And the scanner will do the mutax wrapping around find_char_position. This will making the requirement clear but also simplify the usage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I'm hoping this is the solution for #2446
My hypothesis is that we're seeing a concurrency issue where threads switch in the middle of locating targets and then the document gets mutated. That would render the location we're currently searching for invalid, which can then lead to infinite loops.
Implementation
My idea is to move our mutex into the global state so that we can use it in more places. Then we lock the mutex while locating targets to avoid having any document edits be applied in the middle.
Note: I experimented with passing the mutex down to the document instances, but it was a bit messier.