VSCode extension checks multiple install locations for mise binary

[adam12]

Motivation

The installation path of Mise differs through the installation method chosen. Using Homebrew results in a path under /opt/homebrew where as the installation method from the Mise website is typically under $HOME/.local.

Implementation

When a custom mise path is not defined, 2 potential installation locations are tried instead.

Automated Tests

Skipping for now per discussion in PR.

Manual Tests

Extension manually started and observed Mise path of /opt/homebrew detected in logs.

2024-12-12 16:29:05.413 [info] (manager) Discovered version manager mise
2024-12-12 16:29:05.414 [info] (manager) Running command: `/opt/homebrew/bin/mise x -- ruby -W0 -rjson -e 'STDERR.print("RUBY_LSP_ACTIVATION_SEPARATOR" + { env: ENV.to_h, yjit: !!defined?(RubyVM::YJIT), version: RUBY_VERSION, gemPath: Gem.path }.to_json + "RUBY_LSP_ACTIVATION_SEPARATOR")'` in /Users/adam/code/github.com/midstack/manager using shell: /opt/homebrew/bin/fish

Closes #2878

[adam12]

I'd love some feedback/suggestions on how you'd like to see me approach testing this. Did you want me to set up a fake directory tree and confirm that a binary is found?

I didn't notice any other tests that are similar, and even throwing an error inside the existing code block seems to keep all the tests green, so I am presuming this function is mocked and not tested currently.

[vinistock]

Yeah, this is currently mocked in other tests. I think it should be fine to leave this one without tests since it's the same approach of checking directories we're already using in other manager integrations.

[adam12]

Poking around another file, I noticed that there is another instance where mise is checked in a specific path. Likely should be updated as well.

ruby-lsp/vscode/src/ruby.ts

Lines 411 to 421 in 896617a

	try {
	await vscode.workspace.fs.stat(
	vscode.Uri.joinPath(
	vscode.Uri.file(os.homedir()),
	".local",
	"bin",
	"mise",
	),
	);
	this.versionManager = ManagerIdentifier.Mise;
	return;

[vinistock]

Poking around another file, I noticed that there is another instance where mise is checked in a specific path. Likely should be updated as well.

Yeah, we need to refactor that manager detection logic at some point. Each version manager integration should have some function that will return true if it's detect to be installed and then we don't need to duplicate the logic. For now, feel free to duplicate it.

[vinistock]

Thank you for the contribution!