Start accepting any URI scheme in the index #2934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
added
breaking-change
Graphite App
andyw8
reviewed
Nov 28, 2024
andyw8
reviewed
Nov 28, 2024
vinistock
force-pushed
the
11-28-start_accepting_any_uri_scheme_in_the_index
branch
from
a2083e2 to
03f69b8
Compare
andyw8
approved these changes
Nov 29, 2024
vinistock
deleted the
11-28-start_accepting_any_uri_scheme_in_the_index
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Another step towards #1908
After the recent changes, we can now make the index treat entries coming from any URIs appropriately.
Implementation
The main aspect of change is changing the
@files_to_entriesvariable into@uris_to_entries. Since entries can now be discovered in URIs not backed by a file on disk, we need to be able to add, remove and handle changes based on URIs.Additionally, for synchronizing changes in the index, we need to accept the source now, which will be kept in memory for unsaved files.
Note: this is a breaking change because it means that the
entries_forAPI now needs to accept a URI instead of a file path.Automated Tests
Added a test that verifies all of the important functionality for entries discovered in unsaved URIs.