Chruby test suite looks for ruby binary in multiple locations #2932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support both `/opt/rubies` and `~/.rubies` for installation paths, checking both the `engine-version` and `version` formats. Part of Shopify#2877
adam12
force-pushed
the
chruby-ruby-path
branch
from
757c124 to
a4960bb
Compare
|
I think this could be maybe done more centrally, but it brings my test suite closer to green so perhaps a good middle step? |
vinistock
approved these changes
Nov 29, 2024
There was a problem hiding this comment.
This is definitely the right change as chruby users might have rubies installed in all of those possible locations.
We will also need to consider how to make this test pass for non chruby users. For example, rbenv users will have their rubies installed under ~/.rbenv/rubies or something like that, so this test still won't pass.
Maybe it can check for all of those possible locations and if none are available, skip?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support both
/opt/rubiesand~/.rubiesfor installation paths, checking both theengine-versionandversionformats.Part of #2877