Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move URI extension to indexer #2915

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Move URI extension to indexer #2915

merged 1 commit into from
Nov 27, 2024

Conversation

vinistock
Copy link
Member

@vinistock vinistock commented Nov 26, 2024 •
edited
Loading

Motivation

Move our URI extension to the indexer, so that we can get rid of IndexablePath and use URIs only (which is the first step to address #1908).

Implementation

This PR just moves the extension to the indexer.

@vinistock vinistock added the server This pull request should be included in the server gem's release notes label Nov 26, 2024 — with Graphite App
@vinistock Graphite App
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@vinistock vinistock added the other Changes that aren't bugfixes, enhancements or breaking changes label Nov 26, 2024 — with Graphite App
@vinistock vinistock mentioned this pull request Nov 26, 2024
Merged
@vinistock vinistock marked this pull request as ready for review November 26, 2024 21:07
@vinistock vinistock requested a review from a team as a code owner November 26, 2024 21:07
@vinistock vinistock merged commit a6842f1 into main Nov 27, 2024
43 checks passed
@vinistock vinistock deleted the 11-26-move_uri_extension_to_indexer branch November 27, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyw8 andyw8 andyw8 approved these changes

@alexcrocha alexcrocha Awaiting requested review from alexcrocha

@st0012 st0012 Awaiting requested review from st0012

Assignees
No one assigned
Labels
other Changes that aren't bugfixes, enhancements or breaking changes server This pull request should be included in the server gem's release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vinistock @andyw8