Declare type in initializer for RubyIndexer::Enhancement
#2895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow us to remove the shim from addons which use Sorbet, such as ruby-lsp-rails.
andyw8
added
chore
vinistock
reviewed
Nov 21, 2024
| @@ -33,7 +33,7 @@ def clear | |||
|
|
|||
| sig { params(listener: DeclarationListener).void } | |||
| def initialize(listener) | |||
| @listener = listener | |||
| @listener = T.let(listener, RubyIndexer::DeclarationListener) | |||
There was a problem hiding this comment.
How will this eliminate the need for the shim? Tapioca doesn't carry instance variable declarations to the RBIs AFAIK.
Also, Sorbet already knows the right type for @listener thanks to the method signature.
There was a problem hiding this comment.
Ah true.
Would it be possible to distribute the shim with this gem?
There was a problem hiding this comment.
We can try, but I'm not sure if Tapioca picks up instance variable types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow us to remove the shim from add-ons which use Sorbet, such as ruby-lsp-rails.