Allow configuring rbenv executable path #2875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've just signed the CLA |
vinistock
added
enhancement
vinistock
reviewed
Nov 18, 2024
|
You can fix the linting errors with |
vinistock
approved these changes
Nov 19, 2024
Thanks to you for your guidance! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Ref #2822 (comment)
Allow configuring the rbenv executable path if it's not installed in the default location and cannot be found automatically.
Implementation
Added a new setting under version manager. If the value is set to something, we use that as the rbenv path, otherwise we fallback to the default installation path.
Implementation also makes sure that the specified path exists.
This has been inspired by #1914
Automated Tests
Added a test to verify that we use the configured value to invoke rbenv.