Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sorbet troubleshooting note #2871

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Conversation

andyw8
Copy link
Contributor

@andyw8 andyw8 commented Nov 18, 2024

Motivation

Document this implicit Ruby LSP behavior for the benefit of users trying to set up or troubleshoot their editor.

Implementation

Add a note to the docs.

Automated Tests

n/a

Manual Tests

n/a

@andyw8 andyw8 added documentation Improvements or additions to documentation server This pull request should be included in the server gem's release notes labels Nov 18, 2024
@andyw8 andyw8 requested a review from a team as a code owner November 18, 2024 17:17
@andyw8
Copy link
Contributor Author

andyw8 commented Nov 18, 2024

cc @ChallaHalla

@andyw8 andyw8 force-pushed the andyw8/add-sorbet-troubleshooting-note branch 2 times, most recently from e4d6949 to 9416ce6 Compare November 18, 2024 17:21
Copy link
Member

@vinistock vinistock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also check if the user has the Sorbet extension and, if not, enforce that our features will be enabled.

@andyw8
Copy link
Contributor Author

andyw8 commented Nov 18, 2024

We should also check if the user has the Sorbet extension and, if not, enforce that our features will be enabled.

Yes: #2856

@andyw8 andyw8 enabled auto-merge (squash) November 18, 2024 20:04
@andyw8 andyw8 force-pushed the andyw8/add-sorbet-troubleshooting-note branch from 9416ce6 to 95e0290 Compare November 18, 2024 20:07
@andyw8 andyw8 merged commit adf28bd into main Nov 18, 2024
35 checks passed
@andyw8 andyw8 deleted the andyw8/add-sorbet-troubleshooting-note branch November 18, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation server This pull request should be included in the server gem's release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants