Check target precision for call node in hover and definition #2870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
force-pushed
the
11-18-check_target_precision_for_call_node_in_hover_and_definition
branch
from
3b93343 to
06fc55a
Compare
vinistock
added
server
Graphite App
andyw8
approved these changes
Nov 18, 2024
vinistock
deleted the
11-18-check_target_precision_for_call_node_in_hover_and_definition
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #2846
We had a regression in our call node target precisions. Essentially, the call node covers both the receiver and the message, but we only want to make the call node the target is the position covers the message location exactly.
Implementation
Added another branch to the checks for whether the position is covered or not.
Automated Tests
Added tests to ensure we don't regress.