Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update sample codes on Add-ons page to fix execution errors #2869

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Update sample codes on Add-ons page to fix execution errors #2869

merged 1 commit into from
Nov 18, 2024

Conversation

kozy4324
Copy link
Contributor

Motivation

After implementing using the sample code as a reference, I encountered some errors and resolved them.

Implementation

Automated Tests

Manual Tests

$ cd jekyll
$ bundle install
$ bundle exec jekyll serve

Navigate to http://127.0.0.1:4000/ruby-lsp/add-ons.html

@kozy4324 kozy4324 requested a review from a team as a code owner November 18, 2024 10:15
@vinistock vinistock added the documentation Improvements or additions to documentation label Nov 18, 2024
vinistock
vinistock approved these changes Nov 18, 2024
View reviewed changes
Copy link
Member

@vinistock vinistock left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

When the CLA check passes, we can merge.

@kozy4324
Copy link
Contributor Author

I have signed the CLA!

@andyw8 andyw8 added the server This pull request should be included in the server gem's release notes label Nov 18, 2024
@andyw8 andyw8 enabled auto-merge (squash) November 18, 2024 14:53
@vinistock vinistock removed the server This pull request should be included in the server gem's release notes label Nov 18, 2024
@andyw8 andyw8 merged commit 9926887 into Shopify:main Nov 18, 2024
24 checks passed
@kozy4324 kozy4324 deleted the update-sample-codes-on-add-ons-page branch November 18, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinistock vinistock vinistock approved these changes

@andyw8 andyw8 andyw8 approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kozy4324 @andyw8 @vinistock