Prevent full indexing (index_all) from being called multiple times
#2864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyw8
added
the
server
andyw8
changed the title
index_all being called multiple timesindex_all) from being called multiple times
vinistock
reviewed
Nov 18, 2024
vinistock
approved these changes
Nov 18, 2024
andyw8
force-pushed
the
andyw8/prevent-index-all-being-called-multiple-times
branch
from
a6f3fec to
be72efe
Compare
andyw8
deleted the
andyw8/prevent-index-all-being-called-multiple-times
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the RubyConf 2024 hackday, while exploring some indexing behaviour using
irb, there was some confusion because the index was referring to code that had been deleted.In this PR, I've added a check that raises on attempting to called
index_allif it already contains entries.We could use a more technical approach such as adding a
reindexmethod, or clearing the index each time when callingindex_all. But since this is a relative rare usage, I think this protection is enough for the time being.