Allow indexing enhancements to create namespaces #2857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
force-pushed
the
11-14-allow_indexing_enhancements_to_create_namespaces
branch
from
aa609e0 to
52feb7e
Compare
vinistock
added
breaking-change
Graphite App
|
cc @toddkummer |
vinistock
force-pushed
the
11-14-allow_indexing_enhancements_to_create_namespaces
branch
from
52feb7e to
bb3a5b2
Compare
andyw8
reviewed
Nov 19, 2024
andyw8
reviewed
Nov 19, 2024
Co-authored-by: Alex Rocha <[email protected]>
vinistock
force-pushed
the
11-14-allow_indexing_enhancements_to_create_namespaces
branch
from
bb3a5b2 to
fce492d
Compare
andyw8
approved these changes
Nov 20, 2024
vinistock
deleted the
11-14-allow_indexing_enhancements_to_create_namespaces
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We realized that in order to support concerns
class_methods do...end, indexing enhancements needed to be more powerful and have the liberty to create fake/temporary namespaces.When trying to make that possible, we also realized that the API had many shortcomings that made enhancements harder than they had to be.
Implementation
The idea is to instantiate enhancements with the declaration listener and then expose the API from it. That way, the declaration listener can hold important state like the code units cache and the current file path and enhancements only make flow adjustments and additions to the indexing process.
This PR also allows enhancements to create modules and classes, which allows us to support
class_methods do...endin the Rails add-on and allows the RSpec add-on to supportletandsubjectproperly.Automated Tests
Added tests.