Add support for extend self to handle_module_operation
#2855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlemburg
force-pushed
the
tlemburg/2782-support-extend-self
branch
from
82b49a9 to
23fc41b
Compare
andyw8
added
enhancement
tlemburg
force-pushed
the
tlemburg/2782-support-extend-self
branch
from
23fc41b to
69634b6
Compare
vinistock
approved these changes
Nov 18, 2024
By adding the instance methods as class methods through the singleton mixin operations, we are able to get all instance methods "copied" over into the class methods implicitly. I don't think it's necessary to test whether this extend self applies when the module is opened after being closed again, or re-opened in another file. Closes Shopify#2782
tlemburg
force-pushed
the
tlemburg/2782-support-extend-self
branch
from
69634b6 to
935eebd
Compare
|
Thanks for your contribution! |
You're welcome! Great you meet you and @andyw8 at the conf! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By adding the instance methods as class methods through the singleton mixin operations, we are able to get all instance methods "copied" over into the class methods implicitly.
I don't think it's necessary to test whether this extend self applies when the module is opened after being closed again, or re-opened in another file, but we can add that as well if preferred.
Motivation
Closes #2782
Implementation
I simply allowed a
SelfNodeas an argument to enter thehandle_module_operationmethod and then utilizedan
Includeentry to include the methods onto the singleton.Automated Tests
Added tests checking that the method resolves as an instance method to the class as well as a class method. Further, we also test the inheritance tree for the singleton class.
Manual Tests
Tried a test file and ensured that methods were represented as class methods: